Clarify monitor and detector handling guidelines #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Feb 27, 2024
| - Avoids loading large data into memory that is not needed for the reduction. | ||
| - Avoids keeping large data alive in memory if output metadata extraction depends on auxiliary input data or input metadata. | ||
| Monitor data can be extremely large when operating in event mode. | ||
| Loading only individual monitors avoids loading unnecessary data and allows for more efficient parallelism and reduction in memory use. |
There was a problem hiding this comment.
Not really related to guidelines, but what about transforms? Are there cases where we need to load more than just a monitor in order to find the position? Same for detectors.
There was a problem hiding this comment.
This can be handled by the loader. We should probably put this into ESSreduce (or even ScippNexus), and just wrap that elsewhere.
There was a problem hiding this comment.
That means reimplementing the logic to walk depends-on chains. So it seems to be something that should be handled by compute_positions or a similar function in ScippNexus.
jl-wynen
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case I updated some guidelines IDs, which we should generally avoid. As this was just merged this morning and is not implemented anywhere I think this should be ok.