Add ess.reduce.live, a module for building live reduction workflows
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Oct 10, 2024
| # Beamlime passes full path, but the workflow only needs the name of the monitor | ||
| # or detector group. | ||
| nxevent_data = { | ||
| key.lstrip('/').split('/')[2]: value for key, value in nxevent_data.items() |
There was a problem hiding this comment.
Is there a less brittle way we can make a key without relying on the number 2?
There was a problem hiding this comment.
I think all NeXus files I have seen have monitors and detectors in /entry/instrument/<name>. Can't think of a simple option that will not be even more brittle. Let us fix it when it causes trouble?
nvaytet
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early version, and I expect several cycles of additions and modifications. I am using this with so far 3 workflows in ESSsans, which has driven/informed what should go into this module. The
livemodule uses thestreamingmodule, but operates on a slightly higher level and is more tailored towards Beamlime.