Load histogram monitors #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
force-pushed
the
histogram-monitors
branch
from
d7f1dc7
to
9ffd2d1
Compare
MridulS
approved these changes
Sep 24, 2024
|
|
||
| def assemble_monitor_histogram_data( | ||
| monitor: AnyRunAnyCalibratedMonitor, | ||
| hist_data: AnyRunAnyNeXusMonitorEventData, |
There was a problem hiding this comment.
Suggested change
| hist_data: AnyRunAnyNeXusMonitorEventData, | |
| hist_data: AnyRunAnyNeXusMonitorHistData, |
| @@ -147,6 +147,49 @@ def _select_unique_array( | |||
| return next(iter(arrays.values())) | |||
|
|
|||
|
|
|||
| def load_hist_data( | |||
| file_path: AnyRunFilename, | |||
| selection=(), | |||
There was a problem hiding this comment.
selection isn't documented or type hinted.
Merged
|
@jl-wynen should we close this one? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to load histogram data for monitors instead of event data. While we may not need this in production, simulated data may use histogram monitors instead of event monitors.
In particular, ESSspectroscopy needs this feature. I tested it locally with that pacakge. Note #103 about testing.