Update dependencies. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,7 @@ dependencies = [ | |||
| "scipp>=23.8.0", | |||
| "scippnexus>=23.9.0", | |||
| "pooch", | |||
| "defusedxml", | |||
There was a problem hiding this comment.
Can you explain the choice of a third-party library over something builtin in Python? Do you consider the data we get untrusted?
There was a problem hiding this comment.
This one was recommended by the bandit check because of a security vulnerability of builtin package for xml...
Builtin package xml was not allowed when I tried to commit the code.
SimonHeybrock
approved these changes
Dec 22, 2023
YooSunYoung
force-pushed
the
dependency-update
branch
from
eb44a0c
to
ba72291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dependencies.
TODO:
Nightly dependency could not be compiled since I was using mac os and my workstation is offline...