Merge pull request #85 from scipp/fix-geometry

Rotated detector pixel offset based on the starting position.
scipp · Sep 30, 2024 · ef0d80e · ef0d80e
2 parents 24da326 + 5c39817
commit ef0d80e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/ess/nmx/mcstas/xml.py b/src/ess/nmx/mcstas/xml.py
@@ -338,8 +338,11 @@ def _pixel_positions(
     return (
         (pixel_n_slow * slow_axis_steps)
         + (pixel_n_fast * fast_axis_steps)
-        + position_offset
-    )
+        + detector.rotation_matrix
+        * sc.vector(
+            [detector.start_x, detector.start_y, 0.0], unit=position_offset.unit
+        )  # Detector pixel offset should also be rotated first.
+    ) + position_offset
 
 
 def _detector_pixel_positions(