PoC new inventory table #7422
PoC new inventory table #7422
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -591,6 +603,7 @@ var MyModuleRepositories = (function() { | |||
| }); | |||
|
|
|||
| FULL_VIEW_MODAL.on('hidden.bs.modal', function() { | |||
| return | |||
| @@ -448,7 +460,7 @@ var MyModuleRepositories = (function() { | |||
| repositoryTable.attr('data-version-label', $(this).data('footer-label')); | |||
| repositoryTable.attr('data-name-column-id', $(this).data('name-column-id')); | |||
| repositoryTable.attr('data-stock-management', $(this).data('data-stock-management')); | |||
| repositoryContainer.html(repositoryTable); | |||
| //repositoryContainer.html(repositoryTable); | |||
There was a problem hiding this comment.
Expected space or tab after '//' in comment spaced-comment
| ); | ||
| updateFullViewRowsCount(tableContainer.attr('data-assigned-items-count')); | ||
| window.mountRepositoryTable(); | ||
| return |
| @@ -210,6 +210,9 @@ var MyModuleRepositories = (function() { | |||
| } | |||
|
|
|||
| function renderSimpleTable(tableContainer) { | |||
| console.log(tableContainer.attr('data-element')) | |||
| window.mountRepositoryTable(tableContainer.attr('data-element')); | |||
| return | |||
| @@ -210,6 +210,9 @@ var MyModuleRepositories = (function() { | |||
| } | |||
|
|
|||
| function renderSimpleTable(tableContainer) { | |||
| console.log(tableContainer.attr('data-element')) | |||
There was a problem hiding this comment.
Missing semicolon semi
Unexpected console statement no-console
| user: current_user, | ||
| column: stock_cell.repository_column, | ||
| repository: repository, | ||
| options: {reminders_enabled: reminders_enabled} |
There was a problem hiding this comment.
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
| if has_stock_management | ||
| stock_cell = object.repository_cells.find { |cell| cell.value_type == 'RepositoryStockValue' } | ||
| stock_column = repository.repository_columns.find_by(data_type: 'RepositoryStockValue') | ||
| col_key = 'col_' + stock_column.id.to_s |
There was a problem hiding this comment.
[Correctable] Style/StringConcatenation: Prefer string interpolation to string concatenation.
| user: current_user, | ||
| column: cell.repository_column, | ||
| repository: repository, | ||
| options: {reminders_enabled: reminders_enabled} |
There was a problem hiding this comment.
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
| @@ -0,0 +1,109 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class Lists::RepositoryRowSerializer < ActiveModel::Serializer | |||
There was a problem hiding this comment.
[Correctable] Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
| # .group('repository_sort_cells.repository_row_id') | ||
| # else | ||
| # cells | ||
| # .select("repository_sort_cells.repository_row_id, #{sorting_data_type::SORTABLE_COLUMN_NAME} AS value") |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [125/120]
What was done
PoC new inventory table