Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hdf5 error when dpp are present #1092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gagnonanthony
Copy link
Contributor

@gagnonanthony gagnonanthony commented Dec 12, 2024

Quick description

The reconstruct_sft_from_hdf5 was considering dps as dpp when trying to load an hdf5 with dps (e.g., after commit of afd_fixel computation). There was simply a .shape missing in the assertion.

Closes #960

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Tested it locally, works fine now.

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (e256482) to head (f2de323).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   69.46%   69.46%           
=======================================
  Files         447      447           
  Lines       24052    24052           
  Branches     3291     3291           
=======================================
  Hits        16708    16708           
  Misses       5946     5946           
  Partials     1398     1398           
Components Coverage Δ
Scripts 70.26% <ø> (ø)
Library 68.39% <0.00%> (ø)

@arnaudbore arnaudbore added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply transform to hdf5 error when DPP are present
2 participants