Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a None sentinel for transformers, but not columns. Having a None sentinel for the columns allows a set of transformers to act on all columns of the incoming dataframe.
None sentinel for columns is important, because sometimes we don't know the columns of the dataframe. For instance, if DataFrameMapper is embedded in a long sklearn Pipeline that may have added many columns to the original dataframe, it's hard to know exact column names in the dataframe that comes in (but we may want to apply some transfomrers to all columns).
This feature also bridges the gap to make DataFrameMapper a fully-fledged PandasFeatureUnion. - something that has been requested multiple times in Issue #62 , #64 , and #69 .