Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix test failures due to updated packages: deprecated pytest.warns(None) syntax + GLasso update in sklearn #357

Merged

Conversation

bellet
Copy link
Member

@bellet bellet commented Aug 2, 2024

This PR fixes two problems due to updates in pytest and sklearn:

@bellet bellet changed the title Fix GLasso import for SDML for newer sklearn versions [MRG] Fix GLasso import for SDML for newer sklearn versions Aug 2, 2024
@bellet bellet changed the title [MRG] Fix GLasso import for SDML for newer sklearn versions [MRG] Fix test failures due to updated packages: deprecated pytest.warns(None) syntex + GLasso update in sklearn Aug 2, 2024
@bellet bellet changed the title [MRG] Fix test failures due to updated packages: deprecated pytest.warns(None) syntex + GLasso update in sklearn [MRG] Fix test failures due to updated packages: deprecated pytest.warns(None) syntax + GLasso update in sklearn Aug 2, 2024
@bellet
Copy link
Member Author

bellet commented Aug 2, 2024

This is ready to review/merge.

Note: I have not added the warnings.simplefilter("error") to filter errors as in all case we are either checking for a particular type of warning or to seek catch any warning/error.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@perimosocordiae perimosocordiae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing the private function isn't ideal, but for now it should be ok.

@perimosocordiae perimosocordiae merged commit dc7e449 into scikit-learn-contrib:master Aug 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants