Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2. [MRG] Bilinear similarity #329

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

2. [MRG] Bilinear similarity #329

wants to merge 65 commits into from

Commits on Oct 4, 2021

  1. Remove 3.9 from compatibility

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    4b7cdec View commit details
    Browse the repository at this point in the history

  2. FIrst draft of bilinear mixin

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    0147c0c View commit details
    Browse the repository at this point in the history

  3. Fix score_pairs

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    ec09f59 View commit details
    Browse the repository at this point in the history

  4. Two implementations for score_pairs

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    ec49397 View commit details
    Browse the repository at this point in the history

  5. Generalized toy tests

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    2f3c3e1 View commit details
    Browse the repository at this point in the history

  6. Handmade tests incorporated

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    c21d283 View commit details
    Browse the repository at this point in the history

  7. Fix identation for bilinear

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    dbe2a7a View commit details
    Browse the repository at this point in the history

  8. Add performance test to choose between two methods for bilinear calc

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    ee5c5ee View commit details
    Browse the repository at this point in the history

  9. Found an efficient way to compute Bilinear Sim for n pairs

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    9a10e06 View commit details
    Browse the repository at this point in the history

  10. Update method's descriptions

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    b1edc46 View commit details
    Browse the repository at this point in the history

  11. Following the correct testing structure

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    ae562e6 View commit details
    Browse the repository at this point in the history

  12. Fix identation

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    7ebc026 View commit details
    Browse the repository at this point in the history

  13. Add more tests. Fix 4 to 2 identation

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    1d752f7 View commit details
    Browse the repository at this point in the history

  14. Minor flake8 fix

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    45c9b97 View commit details
    Browse the repository at this point in the history

  15. Commented each test

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    407f910 View commit details
    Browse the repository at this point in the history

  16. All tests have been generalized

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    80c9085 View commit details
    Browse the repository at this point in the history

  17. Fix flake8 identation

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    90ac550 View commit details
    Browse the repository at this point in the history

  18. Minor details

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    68eeda9 View commit details
    Browse the repository at this point in the history

  19. Remove 3.9 from compatibility

    @mvargas33
    mvargas33 authored and mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    c47797c View commit details
    Browse the repository at this point in the history

  20. First draft of refactoring BaseMetricLearner and Mahalanobis Learner

    mvargas33 committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    e07b11a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Avoid warning related to score_pairs deprecation in tests of pair_cal… 

    …ibraiton
    mvargas33 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    8210acd View commit details
    Browse the repository at this point in the history

  2. Minor fix

    mvargas33 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    11b5df6 View commit details
    Browse the repository at this point in the history

  3. Replaced score_pairs with pair_distance in tests

    mvargas33 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    06b7131 View commit details
    Browse the repository at this point in the history

  4. Replace score_pairs with pair_distance inb docs.

    mvargas33 committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d5cb8b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Fix weird commit

    mvargas33 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    2f61e7b View commit details
    Browse the repository at this point in the history

  2. Fix weird commit

    mvargas33 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    9dd38aa View commit details
    Browse the repository at this point in the history

  3. Update classifiers to use pair_similarity

    mvargas33 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    5f68ed2 View commit details
    Browse the repository at this point in the history

  4. Updated rst docs

    mvargas33 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    3d6450b View commit details
    Browse the repository at this point in the history

  5. Fix identation

    mvargas33 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    7bce493 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Update docs of score_pairs, get_metric

    mvargas33 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    7e6584a View commit details
    Browse the repository at this point in the history

  2. Add deprecation Test. Fix identation

    mvargas33 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    0b58f45 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into score-deprecation

    mvargas33 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    d4d3a9c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'score-deprecation' into feat-bilinear

    mvargas33 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    d27bdf5 View commit details
    Browse the repository at this point in the history

  5. Refactor to use pair_similarity instead of score_pairs

    mvargas33 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    78a205c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Add more testing. Test refactor TBD

    mvargas33 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    dde3576 View commit details
    Browse the repository at this point in the history

  2. Tests are now parametrized

    mvargas33 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3020110 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Add bilinear in introduction

    mvargas33 committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    2746668 View commit details
    Browse the repository at this point in the history

  2. Minor comment on use case

    mvargas33 committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    920e504 View commit details
    Browse the repository at this point in the history

  3. More changes to sueprvised

    mvargas33 committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    7a24319 View commit details
    Browse the repository at this point in the history

  4. Changes in weakly Supervised

    mvargas33 committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    2f8ee76 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Merge remote-tracking branch 'upstream/master' into score-deprecation

    mvargas33 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    60c88a6 View commit details
    Browse the repository at this point in the history

  2. Fixed changes requested 1

    mvargas33 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    8c55970 View commit details
    Browse the repository at this point in the history

  3. Fixed changes requested 2

    mvargas33 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    787a8d1 View commit details
    Browse the repository at this point in the history

  4. Add equivalence test, p_dist == p_score

    mvargas33 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    e14f956 View commit details
    Browse the repository at this point in the history

  5. Fix tests and identation.

    mvargas33 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    0941a32 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Fixed changes requested 3

    mvargas33 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    b019d85 View commit details
    Browse the repository at this point in the history

  2. Fix identation

    mvargas33 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    74df897 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Last requested changes

    mvargas33 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    c62a4e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'score-deprecation' into feat-bilinear

    mvargas33 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    526e4ba View commit details
    Browse the repository at this point in the history

  3. Replaced pair_similarity for paiir_score

    mvargas33 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    2199724 View commit details
    Browse the repository at this point in the history

  4. Last small detail

    mvargas33 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    249e0fe View commit details
    Browse the repository at this point in the history

  5. Merge branch 'score-deprecation' into feat-bilinear

    mvargas33 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    80f31ba View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge remote-tracking branch 'upstream/master' into feat-bilinear

    mvargas33 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    8df44a4 View commit details
    Browse the repository at this point in the history

  2. Classifiers only test classifiers methods now. + Standard doctrings now.

    mvargas33 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    eef13bb View commit details
    Browse the repository at this point in the history

  3. Work in tests. More comments. Some refactors

    mvargas33 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    b952af0 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Learner lists for M and B learners. Separated test by kind. Mock clas… 

    …s B weakly learners. Tests refactor.
    mvargas33 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7cc0d5e View commit details
    Browse the repository at this point in the history

  2. Moved mocks to test_utils.py, then refactor test_bilinear_mixin.py

    mvargas33 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    5f6bdc2 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Merge branch 'master' into feat-bilinear

    mvargas33 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    100a05d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Resolved observations in interoduction.rst

    mvargas33 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    3bf5eae View commit details
    Browse the repository at this point in the history

  2. Resolved all observations for supervised.rst and weakly_s.rst

    mvargas33 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    acfd54b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Spellcheck

    mvargas33 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    69bd9fe View commit details
    Browse the repository at this point in the history

  2. Moved common test to test_base_metric.py . Refactor preprocessor test… 

    … to avoid code duplication, trade-off with isinstance(). Added SCML basis that got lost in the list.
    mvargas33 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ade34cc View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Fix docs annotations

    mvargas33 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    7cfd432 View commit details
    Browse the repository at this point in the history

  2. Second chunks of annotations.

    mvargas33 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0ac9e7a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge branch 'master' into feat-bilinear

    @perimosocordiae
    perimosocordiae authored Jun 21, 2022
    Configuration menu
    Copy the full SHA
    98340b0 View commit details
    Browse the repository at this point in the history