Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Threshold for pairs learners #168

Merged
merged 43 commits into from
Apr 15, 2019
Merged

[MRG+1] Threshold for pairs learners #168

merged 43 commits into from
Apr 15, 2019

Commits on Feb 4, 2019

  1. add some tests for testing that different scores work using the scori… 

    …ng function
    William de Vazelhes committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    676ab86 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. ENH: Add tests and basic threshold implementation

    William de Vazelhes committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    cc1c3e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Add support for LSML and more generally quadruplets

    William de Vazelhes committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    f95c456 View commit details
    Browse the repository at this point in the history

  2. Make CalibratedClassifierCV work (for preprocessor case) thanks to cl… 

    …asses_
    William de Vazelhes committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    9ffe8f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Fix some tests and PEP8 errors

    William de Vazelhes committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    3354fb1 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. change the sign in decision function

    William de Vazelhes committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    12cb5f1 View commit details
    Browse the repository at this point in the history

  2. Add docstring for threshold_ and classes_ in the base _PairsClassifie… 

    …r class
    William de Vazelhes committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    dd8113e View commit details
    Browse the repository at this point in the history

  3. remove quadruplets from the test with scikit learn custom scorings

    William de Vazelhes committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    1c8cd29 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Remove argument y in quadruplets learners and lsml

    William de Vazelhes committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    d12729a View commit details
    Browse the repository at this point in the history

  2. FIX fix docstrings of decision functions

    William de Vazelhes committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    dc9e21d View commit details
    Browse the repository at this point in the history

  3. FIX the threshold by taking the opposite (to be adapted to the decisi… 

    …on function)
    William de Vazelhes committed Feb 20, 2019
    1 Configuration menu
    Copy the full SHA
    402729f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Fix tests to have no y for quadruplets' estimator fit

    William de Vazelhes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    aaac3de View commit details
    Browse the repository at this point in the history

  2. Remove isin to be compatible with old numpy versions

    William de Vazelhes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    e5b1e47 View commit details
    Browse the repository at this point in the history

  3. Fix threshold so that it has a positive value and add small test

    William de Vazelhes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    a0cb3ca View commit details
    Browse the repository at this point in the history

  4. Fix threshold for itml

    William de Vazelhes committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    8d5fc50 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. FEAT: Add calibrate_threshold and tests

    William de Vazelhes committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    0f14b25 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. MAINT: remove starred syntax for compatibility with older versions of… 

    … python
    William de Vazelhes committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    a6458a2 View commit details
    Browse the repository at this point in the history

  2. Remove debugging prints and make tests for ITML pass, while waiting for 

    scikit-learn-contrib#175 to be solved
    William de Vazelhes committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    fada5cc View commit details
    Browse the repository at this point in the history

  3. FIX: from __future__ import division to pass tests for python 2.7

    William de Vazelhes committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    32a4889 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Add some documentation for calibration

    William de Vazelhes committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    5cf71b9 View commit details
    Browse the repository at this point in the history

  2. DOC: fix style

    William de Vazelhes committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    c2bc693 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. Merge branch 'master' into feat/add_threshold 

    # Conflicts:
#	doc/conf.py
    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    e96ee00 View commit details
    Browse the repository at this point in the history

  2. Address most comments from aurelien's reviews

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    3ed3430 View commit details
    Browse the repository at this point in the history

  3. Remove classes_ attribute and test for CalibratedClassifierCV

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    69c6945 View commit details
    Browse the repository at this point in the history

  4. Rename make_args_inc_quadruplets into remove_y_quadruplets

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    bc39392 View commit details
    Browse the repository at this point in the history

  5. TST: Fix remaining threshold into min_rate

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    facc546 View commit details
    Browse the repository at this point in the history

  6. Remove default_threshold and put calibrate_threshold instead

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    f0ca65e View commit details
    Browse the repository at this point in the history

  7. Use calibrate_threshold for ITML, and remove description

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    a6ec283 View commit details
    Browse the repository at this point in the history

  8. ENH: use calibrate_threshold by default and display its parameters fr… 

    …om the fit method
    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    49fbbd7 View commit details
    Browse the repository at this point in the history

  9. Add a small test to test automatic calibration

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    960b174 View commit details
    Browse the repository at this point in the history

  10. Update documentation of the default threshold

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    c91acf7 View commit details
    Browse the repository at this point in the history

  11. Inverse sense for threshold comparison to be more intuitive

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    a742186 View commit details
    Browse the repository at this point in the history

  12. Address remaining review comments

    William de Vazelhes committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    9ec1ead View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. MAINT: Rename threshold_params into calibration_params

    William de Vazelhes committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    986fed3 View commit details
    Browse the repository at this point in the history

  2. TST: Add test for extreme cases

    William de Vazelhes committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    3f5d6d1 View commit details
    Browse the repository at this point in the history

  3. MAINT: rename threshold_params into calibration_params

    William de Vazelhes committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    7b5e4dd View commit details
    Browse the repository at this point in the history

  4. MAINT: rename threshold_params into calibration_params

    William de Vazelhes committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    a3ec02c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. FIX: Make tests work, and add the right threshold (mean between lowes… 

    …t accepted value and highest rejected value), and max + 1 or min - 1 for extreme points
    William de Vazelhes committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    ccc66eb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/add_threshold 

    # Conflicts:
#	test/test_mahalanobis_mixin.py
#	test/test_utils.py
    William de Vazelhes committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    6dff15b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Go back to previous version of finding the threshold

    William de Vazelhes committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    719d018 View commit details
    Browse the repository at this point in the history

  2. Extract method for validating calibration parameters

    William de Vazelhes committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    551d161 View commit details
    Browse the repository at this point in the history

  3. Validate calibration params before fit

    William de Vazelhes committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    594c485 View commit details
    Browse the repository at this point in the history

  4. Address scikit-learn-contrib#168 (comment)

    William de Vazelhes committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    14713c6 View commit details
    Browse the repository at this point in the history