Skip to content

Commit

Permalink
Adding Python 3.8 (#145)
Browse files Browse the repository at this point in the history
* Adding Python 3.8

* Fix build with 3.8

* Dropping 3.8 from manylinux1
  • Loading branch information
henryiii authored Oct 16, 2019
1 parent a17e92f commit e6e27d6
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .ci/azure-build-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ jobs:
python.version: '3.6'
Python37:
python.version: '3.7'
Python38:
python.version: '3.8'
pool:
vmImage: 'macOS-10.14'
steps:
Expand Down
11 changes: 11 additions & 0 deletions .ci/build-wheels.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,20 @@ set -e -x
# Collect the pythons
pys=(/opt/python/*/bin)

# Print list of Python's available
echo "All Pythons: ${pys[@]}"

# Filter out Python 3.4
pys=(${pys[@]//*34*/})

# Filter out Python 3.8 on manylinux1
if [[ $PLAT =~ "manylinux1" ]]; then
pys=(${pys[@]//*38*/})
fi

# Print list of Python's being used
echo "Using Pythons: ${pys[@]}"

# Compile wheels
for PYBIN in "${pys[@]}"; do
"${PYBIN}/pip" install -r /io/dev-requirements.txt
Expand Down
3 changes: 3 additions & 0 deletions .ci/macos-install-python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ case $PYTHON_VERSION in
3.7)
FULL_VERSION=3.7.3
;;
3.8)
FULL_VERSION=3.8.0
;;
esac

INSTALLER_NAME=python-$FULL_VERSION-macosx10.9.pkg
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ First beta release and beginning of the changelog.

* Unlimited storage does not support pickling or classic multiprocessing
* Some non-simple storages do not support some forms of access, like `.view`
* Indexing and the array versions (such as centers) are incomplete and subject to change
* The numpy module is provisional and subject to change
* Docstrings and signatures will improve in later versions (especially on Python 3)
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Python bindings for [Boost::Histogram][] ([source][Boost::Histogram source]), a

## Installation

This library is under development, but you can install directly from GitHub if you would like. You need a C++14 compiler and Python 2.7--3.7. Boost 1.71 is not required or needed (this only depends on included header-only dependencies).
This library is under development, but you can install directly from GitHub if you would like. You need a C++14 compiler and Python 2.7--3.8. Boost 1.71 is not required or needed (this only depends on included header-only dependencies).
All the normal best-practices for Python apply; you should be in a virtual environment, otherwise add `--user`, etc.

```bash
Expand Down

0 comments on commit e6e27d6

Please sign in to comment.