fix: use CMake 3.24 & smart downloading

Signed-off-by: Henry Schreiner <[email protected]>

CMakeLists.txt

@@ -1,8 +1,10 @@
-cmake_minimum_required(VERSION 3.15...3.27)
+cmake_minimum_required(VERSION 3.24...3.29)
 
 project(BOOST_HISTOGRAM LANGUAGES CXX)
 # Version is added later
 
+include(FetchContent)
+
 # Boost histogram requires C++14
 set(CMAKE_CXX_STANDARD
     14
@@ -35,16 +37,24 @@ if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
                                                "RelWithDebInfo")
 endif()
 
-# Display versions
-message(STATUS "CMake ${CMAKE_VERSION}")
-
 # Adding pybind11 and setting up Python
 # Will display pybind11 version
 set(PYBIND11_FINDPYTHON TRUE)
 set(Python_ARTIFACTS_INTERACTIVE TRUE)
-add_subdirectory(extern/pybind11)
 
+FetchContent_Declare(
+  pybind11
+  GIT_REPOSITORY https://github.com/pybind/pybind11.git
+  GIT_TAG 3e9dfa2866941655c56877882565e7577de6fc7b # v2.12.0
+  FIND_PACKAGE_ARGS NAMES pybind11)
+FetchContent_MakeAvailable(pybind11)
+
+# Display versions
+message(STATUS "CMake ${CMAKE_VERSION}")
 message(STATUS "Python ${Python_VERSION_MAJOR}.${Python_VERSION_MINOR}")
+if(DEFINED pybind11_VERSION)
+  message(STATUS "pybind11 ${pybind11_VERSION}")
+endif()
 
 # This is completely optional and just adds hints to IDEs - no affect on build at all.
 file(GLOB_RECURSE BOOST_HIST_FILES "extern/histogram/include/*.hpp")

noxfile.py

@@ -1,11 +1,12 @@
 from __future__ import annotations
 
 import argparse
-import shutil
 from pathlib import Path
 
 import nox
 
+nox.needs_version = ">=2024.3.2"
+nox.options.default_venv_backend = "uv|virtualenv"
 nox.options.sessions = ["lint", "tests"]
 
 
@@ -15,7 +16,6 @@ def tests(session: nox.Session) -> None:
     Run the unit and regular tests.
     """
 
-    shutil.rmtree("build", ignore_errors=True)
     session.install(".[test]")
     session.run("pytest", *session.posargs)
 
@@ -26,7 +26,6 @@ def testsnp2(session: nox.Session) -> None:
     Run the unit and regular tests with NumPy 2.
     """
 
-    shutil.rmtree("build", ignore_errors=True)
     session.install(".[test]", "numpy>=2.0a1")
     session.run("pytest", *session.posargs)
 
@@ -36,7 +35,6 @@ def hist(session: nox.Session) -> None:
     """
     Run Hist's test suite
     """
-    shutil.rmtree("build", ignore_errors=True)
     session.install(".")
     tmpdir = session.create_tmp()
     session.chdir(tmpdir)

pyproject.toml

@@ -1,5 +1,5 @@
 [build-system]
-requires = ["scikit-build-core[pyproject]"]
+requires = ["scikit-build-core[pyproject]", "pybind11"]
 build-backend = "scikit_build_core.build"
 
 [project]
@@ -95,6 +95,8 @@ Homepage = "https://github.com/scikit-hep/boost-histogram"
 metadata.version.provider = "scikit_build_core.metadata.setuptools_scm"
 sdist.include = ["src/boost_histogram/version.py"]
 wheel.expand-macos-universal-tags = true
+minimum-version = "0.8"
+cmake.version = ">=3.24"
 
 
 [tool.setuptools_scm]