fix: minor things before release (#795)

* ci: auto-cancel on repeated pushes Signed-off-by: Henry Schreiner <[email protected]> * fix: better location of warning Signed-off-by: Henry Schreiner <[email protected]> * style: pre-commit fixes * docs: prepare changelog Signed-off-by: Henry Schreiner <[email protected]> * style: pre-commit fixes * docs: update examples Signed-off-by: Henry Schreiner <[email protected]> * docs: fix examples Signed-off-by: Henry Schreiner <[email protected]> * chore: include Python 3.11 classifiers Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
scikit-hep · Sep 19, 2022 · 9927fec · 9927fec
1 parent 203812f
commit 9927fec
Show file tree

Hide file tree

Showing 9 changed files with 210 additions and 139 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,6 +11,10 @@ on:
 env:
   FORCE_COLOR: 3
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   clang-tidy:
     name: Clang-Tidy

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -43,7 +43,7 @@ repos:
   rev: v2.0.0
   hooks:
   - id: setup-cfg-fmt
-    args: [--include-version-classifiers, --max-py-version=3.10]
+    args: [--include-version-classifiers, --max-py-version=3.11]
 
 - repo: https://github.com/hadialqattan/pycln
   rev: v2.1.1

diff --git a/dev-requirements.txt b/dev-requirements.txt
@@ -7,3 +7,4 @@ pytest-benchmark
 setuptools >=42
 setuptools_scm[toml] >=3.4,!=4.0.0
 typing_extensions; python_version<'3.8'
+uproot
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -2,26 +2,21 @@
 
 ## Version 1.3
 
-### WIP
-
-#### Bug Fixes
-
-* Avoid the constructor when creating new histograms from existing ones. [#759][]
-
-[#759]: https://github.com/scikit-hep/boost-histogram/pull/759
-
 ### Version 1.3.2
 
 #### Changes
 
 * Added `storage_type` operator and `storage_type()` function [#781][], with pending deprecation for `_storage_type`. [#786][] [#790][]
 * Better errors generated for missing or incorrect sample to mean storage. [#782][]
+* Better error message when views are set with an incompatible array. [#794][]
 
 #### Bug fixes
 
 * Patch broken sum with fully empty (0 bin) axis. [#718][]
 * Fix zero range `bh.numpy.histogram` to match `numpy.histogram` behavior. [#721][]
 * Avoid triggering `__init__` when copying (better support for subclasses with custom init's). [#759][]
+* IntCategory now supports numbers larger than 2^24 (now 2^53). [#792][]
+* Pick a subset now supported inside a larger expression. [#793][]
 
 #### Backend and docs
 
@@ -31,6 +26,7 @@
 * Using pybind11 2.10 [#767][]
 * Explicit `reset()` documentation. [#783][]
 * Minor cleanup and further removal of a little Python 2 back-compat code.
+* Warnings have better stacklevel settings.
 
 [#718]: https://github.com/scikit-hep/boost-histogram/pull/718
 [#721]: https://github.com/scikit-hep/boost-histogram/pull/721
@@ -44,6 +40,9 @@
 [#786]: https://github.com/scikit-hep/boost-histogram/pull/786
 [#789]: https://github.com/scikit-hep/boost-histogram/pull/789
 [#790]: https://github.com/scikit-hep/boost-histogram/pull/790
+[#792]: https://github.com/scikit-hep/boost-histogram/pull/792
+[#793]: https://github.com/scikit-hep/boost-histogram/pull/793
+[#794]: https://github.com/scikit-hep/boost-histogram/pull/794
 
 ### Version 1.3.1
 

diff --git a/notebooks/BoostHistogramHandsOn.ipynb b/notebooks/BoostHistogramHandsOn.ipynb
diff --git a/notebooks/aghast.ipynb b/notebooks/aghast.ipynb
diff --git a/notebooks/xarray.ipynb b/notebooks/xarray.ipynb
@@ -145,7 +145,7 @@
    "source": [
     "bh_bins = bh.axis.Regular(19, -4, 4)\n",
     "bh_hist = bh.Histogram(bh_bins).fill(np.asarray(da).flatten())\n",
-    "plt.plot(bh_hist.axes[0].centers, bh_hist);"
+    "plt.plot(bh_hist.axes[0].centers, bh_hist.values());"
    ]
   },
   {
@@ -175,7 +175,7 @@
     "\n",
     "    # Now compute the xarray output.\n",
     "    return xr.DataArray(\n",
-    "        h,\n",
+    "        h.values(),\n",
     "        name=\"_\".join(a.name for a in args) + \"_histogram\",\n",
     "        coords=[\n",
     "            (f\"{a.name}_bin\", arr.flatten(), a.attrs)\n",
@@ -267,7 +267,7 @@
     "        h.fill(*prepare_fill, weight=np.asarray(prepared_weights).flatten())\n",
     "\n",
     "    return xr.DataArray(\n",
-    "        h,\n",
+    "        h.values(),\n",
     "        name=\"_\".join(a.name for a in args) + \"_histogram\",\n",
     "        coords=[\n",
     "            (f\"{a.name}_bin\", arr.flatten(), a.attrs)\n",
@@ -527,7 +527,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.6"
+   "version": "3.9.10"
   }
  },
  "nbformat": 4,

diff --git a/setup.cfg b/setup.cfg
@@ -29,6 +29,7 @@ classifiers =
     Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Programming Language :: Python :: 3.10
+    Programming Language :: Python :: 3.11
     Programming Language :: Python :: Implementation :: CPython
     Programming Language :: Python :: Implementation :: PyPy
     Topic :: Scientific/Engineering

diff --git a/src/boost_histogram/_internal/hist.py b/src/boost_histogram/_internal/hist.py
@@ -939,7 +939,8 @@ def __getitem__(  # noqa: C901
 
         if pick_set:
             warnings.warn(
-                "List indexing selection is experimental. Removed bins are not placed in overflow."
+                "List indexing selection is experimental. Removed bins are not placed in overflow.",
+                stacklevel=2,
             )
             logger.debug("Slices for picking sets: %s", pick_set)
             axes = [reduced.axis(i) for i in range(reduced.rank())]