-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CUDA kernels that calculate length/sum #2992
Conversation
e591460
to
0299bab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
feca8b2
to
fdcf96e
Compare
…edArray_numnull_unique_64.cu
@jpivarski I am done with this PR but I am not quite sure why the integration test is failing. All the tests pass locally. Edit: Oh, I just noticed #2998 which refers to this issue. I need to wait for that PR to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look great! I also tested everything on my GPU; there were no errors. We should not merge until after 2.6.0, though.
...wkward/_connect/cuda/cuda_kernels/awkward_IndexedArray_reduce_next_nonlocal_nextshifts_64.cu
Outdated
Show resolved
Hide resolved
@jpivarski Can this be merged now? |
Thanks for formatting it. In the changes since I last viewed, it looks like a lot more kernels were touched. Was it the case that only a few of them were previously formatted in black-style, and now you did all of them? I think this PR will change |
Yes, there were very few that were formatted earlier.
Sure. Thank you. |
Awkward 2.6.1 is out, so this can be merged whenever you want. It is understood that the next version will require a new awkward-cpp. (Unfortunately, that might slow down testing of #3007. Oh well.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
@jpivarski |
@ManasviGoyal if you can hold off on merging, I'll fix these in a separate PR and merge them into main :) Will be about an hour all-in. |
Sure. Thanks! |
New kernels added -
Makes
awkward_ListArray_min_range
more efficient by usingcupy.min
CUDA kernels that are implemented but not optimal #2987Fixes the implemetation of many existing kernels
Adds unit-tests