Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

360-fix-e2e-specs #371

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

360-fix-e2e-specs #371

wants to merge 30 commits into from

Conversation

DaltonMcauliffe
Copy link
Contributor

@DaltonMcauliffe DaltonMcauliffe commented Feb 5, 2024

story

fix the broken browse tests locally. they will still fail in ci due to configuration. (ref: #378)

Co-authored-by: Adrian Carranza [email protected]
Co-authored-by:Jean Aragon [email protected]
Co-authored-by: Alisha Evans [email protected]

Screenshots / Video

image

Testing

  1. pull this branch
  2. ensure you have all of the environment variables in the env property of "cypress.config.js" set up.
  3. run yarn cypress:e2e
  4. choose the "browse" test

notes

if you see an error like the below, it is not because of the test but of another issue that will be handled separately as it has to do with some dynamic forms not being created properly. (this issue should only affect the beachside marketplace, not phenovista. ref: #376)

error image

we're importing the waresFixture so that we can,
access the new request page as an unauthorized user.

- ref: #360

Co-authored-by: alisha evans <[email protected]>
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstore-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 9:49pm

update the spec to account for the "new request" flow as an authorized
and unauthorized user. left TODO's for dalton, adrian and jean to pick
up when they return to this work.
the intercept command was not ever working. now, we are expecting to use
the real api calls instead of mocked ones. this is to ensure that our
critical paths of browsing and creating a request are always working,
even when the api is updated.

I also refactored part of the browse page specs into the home page spec,
since that's the flow it was actually testing. also edited the cypress
config to make it more dynamic, which will help with this code existing
in the various client codebases.
@alishaevn alishaevn linked an issue Feb 8, 2024 that may be closed by this pull request
1 task
there may potentially be hundreds of services on a page. to avoid
a timeout, we will only choose from 10 services. this still ensures
that a variety of dynamic forms are tested
loading a full browse page can take a while. the beachside biotech provider has 585
services and we're loading them all at once. certain services also have more complex
dynamic forms, which could mean it takes longer for them to load. increasing the
timeout for both operations prevents a failure due to time, opposed to assertion.
attempt to get around long timeouts by waiting for an expected element
to be on the page before continuing
when running specs locally with "cypress open" (headed), they pass.
they fail locally when running "cypress run"(headless) for timeout issues.
ci also runs headless, and gets timeout issues. I'm updating the config
to run headed in ci in an attempt to get them to pass.

ref: cypress-io/github-action#403 (comment)
the change in 3479ce0 still erred. I created a new
script for the cypress workflow to call specifically.

ref: cypress-io/github-action#403 (comment)
alishaevn added a commit that referenced this pull request Feb 13, 2024
- set up recording for cypress cloud
- add env variables for the workflows\
- create a new script for cypress in ci

moved this code, and added more to it, from #371
- ref: #378
@alishaevn alishaevn mentioned this pull request Feb 13, 2024
also wait for more elements to appear on the page before running assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix "browse" e2e specs
2 participants