Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show description and not snippet #365

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

summer-cook
Copy link
Contributor

Story

we needed to use the description instead of the snippet in the useAllWares api call. The

related

Expected Behavior Before Changes

the snippet was showing on the browse page in the ware cards

Expected Behavior After Changes

the description should be showing on the browse page in the ware cards

Screenshots / Video

screenshot/video

video:
https://share.zight.com/04uROEJk

screenshot:
image

Notes

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstore-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:51pm

Copy link
Contributor

@labradford labradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should use the snippet as a fallback in case the description is empty?

@summer-cook summer-cook merged commit fe10ae8 into main Feb 1, 2024
3 of 5 checks passed
@alishaevn alishaevn deleted the 345-disable-request-form branch February 8, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants