Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

342 create requests #347

Merged
merged 1 commit into from
Jan 19, 2024
Merged

342 create requests #347

merged 1 commit into from
Jan 19, 2024

Conversation

alishaevn
Copy link
Contributor

@alishaevn alishaevn commented Jan 19, 2024 •
edited
Loading

@alishaevn
able to create requests again
c3f0256 
when a description is not provided, the validations fail. we are now
passing the `data_str` and `dynamic_forms_to_embed` properties when
creating a new request as their presence allow the validations to pass,
even in the absence of a description.

ref:
- https://github.com/assaydepot/rx/blob/main/app/models/pg/quote_group.rb#L778-L781
- https://assaydepot.slack.com/archives/CF6490Y80/p1705098558758609?thread_ts=1704996805.983419&cid=CF6490Y80
@vercel Vercel
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstore-staging ✅ Ready (Inspect) Visit Preview Jan 19, 2024 0:02am

@alishaevn alishaevn merged commit c26bcf8 into main Jan 19, 2024
6 of 7 checks passed
@alishaevn alishaevn deleted the 342-create-requests-v2 branch January 24, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summer-cook summer-cook summer-cook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alishaevn @summer-cook