🐛 Correct search count #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A funky bug was observed when on a parent work of a PDF, the count was off by one. It registers OCR hits as both an OCR hit and a metadata hit. This is likely because of adding snippets in the search since all the file sets' texts need to be indexed on the parent work as well. The parent work essentially would double all the texts found. This commit is a bit hacky but it removes that extra hit while keeping functionality for both OCR hits and metadata hits. This is a bit of future proofing since it only would happen in applications with snippets enabled.
This commit will refactor #annotation_list by breaking it down a bit and also adjusts and compensates the json for removing the invalid hit.
kirkkwang
force-pushed
the
ocr-count-correction
branch
from
2ff9965
to
e175a83
Compare
jeremyf
reviewed
Jul 13, 2023
| def check_coords_json_and_properties(coords_json, sanitized_query) | ||
| return if coords_json && coords_json['coords'] | ||
|
|
||
| properties = @document.keys.select { |key| key.ends_with? "_tesim" } |
There was a problem hiding this comment.
returning_value = INVALID_MATCH_TEXT
@document.each_pair do |key, value|
next if key.ends_with?("_tesim")
next unless value.join.downcase.include?(sanitized_query)
returning_value = default_coords
break
end
end
returning_value
jeremyf
reviewed
Jul 13, 2023
| return default_coords unless coords_json && coords_json['coords'] | ||
| sanitized_query = query.match(additional_query_terms_regex)[1].strip | ||
|
|
||
| coords_check_result = check_coords_json_and_properties(coords_json, sanitized_query) |
There was a problem hiding this comment.
Thinking about moving the guard condition of the original method outside of the original method, as it has a surprising return value (based on the given method name).
return derived_coords_json_and_properties(coords_json, sanitized_query) unless coords_json['coords']
jeremyf
approved these changes
Jul 13, 2023
This commit will bring in review changes and make the method clearer to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Correct search count
A funky bug was observed when on a parent work of a PDF, the count was
off by one. It registers OCR hits as both an OCR hit and a metadata
hit. This is likely because of adding snippets in the search since all
the file sets' texts need to be indexed on the parent work as well. The
parent work essentially would double all the texts found. This commit
is a bit hacky but it removes that extra hit while keeping functionality
for both OCR hits and metadata hits. This is a bit of future proofing
since it only would happen in applications with snippets enabled.
Before
After
♻️ Refactor and fix annotation count
This commit will refactor #annotation_list by breaking it down a bit and
also adjusts and compensates the json for removing the invalid hit.
IIIF Search JSON