🐛 Fix Bulkrax Collection Relationships job #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
force-pushed
the
fix-bulkrax-collection-relationship
branch
from
c289a93
to
38a7265
Compare
ShanaLMoore
reviewed
Nov 27, 2023
laritakr
force-pushed
the
fix-bulkrax-collection-relationship
branch
from
38a7265
to
294437d
Compare
Importing a work with a collection did not add the work to the collection. By moving the Hyrax::BasicMetadata include below the property definition, the relationship job now completes normally and makes the appropriate relationships. refs - #195
laritakr
force-pushed
the
fix-bulkrax-collection-relationship
branch
from
294437d
to
51b62bc
Compare
ShanaLMoore
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Importing a work with a collection did not add the work to the collection. By moving the Hyrax::BasicMetadata include below the property definition, the relationship job now completes normally and makes the appropriate relationships.
refs
Expected Behavior Before Changes
Works were not added to collections via a bulkrax import.
Expected Behavior After Changes
Adding a collection ID to the parents column will create the work's relationship to the appropriate collection.
Screenshots / Video
Notes