Introduces importer permission restrictions #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces an Advanced Depositors group with Work Importer role. Requires rake task to load roles: `rake hyku:roles:create_default_roles_and_groups` Adds new translations to en.yml file only. Requires running a translation service to add other language translations.
Fixes previous spec failures.
Address specs failing due to new role & group
kirkkwang
approved these changes
Nov 22, 2023
Yes I'd assume that they can import anything since this just gives access to Bulkrax. I just mimicked the "work depositor" role when I made the "advanced depositor" role for Bulkrax for consistent terminology. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Introduces an Advanced Depositors group with Work Importer role.
Addresses previously failing ability specs.
Refs
Expected Behavior Before Changes
Importers and exporters are open to everyone
Expected Behavior After Changes
Only Admin user and those in the Advanced Depositor group will have access to importers and exporters
Screenshots / Video
Screenshots
default user with no added permissions
when default user tries /importers route
user in Advanced Depositors group
Admin user
New group and role
Notes
rake hyku:roles:create_default_roles_and_groups