121-embargo-auto-expire #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is copied from samvera/hyrax#6241 to solve #121. In that PR, the ability to expire embargoes using a rake task works. The copied code has not been included in a release yet. At the time of this writing, September 26, 2023, it is in hyrax main. The latest release is `hyrax-v4.0.0`. This app is currently using hyrax-v3.5.0. However, since the changes being brought in are coming from hyrax main, I'm including the entire files instead of writing decorators.
|
the error I'm getting can be seen in the screenshot below. it occurs with these code changes from hyrax main (first commit in this pr), and without them. (the same error occurs, I didn't actually do the step through with the changes to see if the error comes from the same place, but I feel like it does) screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
WIP: this doesn't work as of yet.
This code is copied from samvera/hyrax#6241 to solve #121. In that PR, the ability to expire embargoes using a rake task works.
The copied code has not been included in a release yet. At the time of this writing, September 26, 2023, it is in hyrax main. The latest release is
hyrax-v4.0.0.This app is currently using hyrax-v3.5.0. However, since the changes being brought in are coming from hyrax main, I'm including the entire files instead of writing decorators.
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes