Citations #113
Merged
Citations #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its odd that the linting is still failing even when you added those files to the rubocop_todo.yml. Can you disable/enable rubocop around the lines of code that are throwing those errors? Details on how to do that: |
summer-cook
requested changes
Jul 17, 2023
summer-cook
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
We wanted our citation tool to be like we have it in the digital library. To do this I grabbed all the related citation files from the PALS project and added them to ours. I adjusted Citations to say Cite this item and added some CSS to style them.
I added to the rubocop file to match what PALS had as well - not sure if this was needed or not.
Running rubocop showed 3 issues "Rails/OutputSafety: Tagging a string as html safe may be a security risk. text.html_safe" but since this is the same code that is in PALS I think it must be okay.
Refs #issuenumber
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes