Theming newtheme #111
Theming newtheme #111
Conversation
|
|
||
| <% if controller_name == 'homepage' || | ||
| controller_name == 'pages' || | ||
| controller_name == 'contact_form' |
There was a problem hiding this comment.
did you already try this?
| controller_name == 'contact_form' | |
| controller_name == 'contact_form' || | |
| controller_name == 'catalog' |
There was a problem hiding this comment.
The reason they are separate is that there is a different layout for the top of the catalog page. I was not yet sure if it was similar enough to make that change like i did for the home page on line 24 so i kept it separate. BUT, I just now tried removing the section and adding catalog with the others and it has no affect.
There was a problem hiding this comment.
inside this view, try adding a debugging statement like
<%= raise 'debug' %>
it will show an error page, with a console on it. in the console you can write controller_name to check what the controller is called on that page.
There was a problem hiding this comment.
@summer-cook I added it but only get the error on the pages that were working - it has no affect on the catalog page. so that page is not being used at all when the catalog gets loaded.
| </div> | ||
| <%end%> | ||
|
|
||
| <% if controller_name == 'catalog' %> |
There was a problem hiding this comment.
if the suggestion above works, remove this whole section until line 54
| @@ -6,6 +6,7 @@ | |||
| <%= content_for(:head) %> | |||
| </head> | |||
| <% content_for(:extra_body_classes, 'public-facing') unless params[:controller].match(/^proprietor/) %> | |||
| <% content_for(:extra_body_classes, ' search-only') if current_account && current_account.search_only %> | |||
There was a problem hiding this comment.
check in the inspector in the rendered html that the search-only body class is being correctly applied on the search results page, because it might not be. I noticed you have a space in the string so it reads ' search-only' which may be incorrect.
There was a problem hiding this comment.
So without that space it makes public-facing and search-only into public-facingsearch-only and all the css stops working.
There was a problem hiding this comment.
I put the debugger bit in this file and reloaded the search results page and then put controller_name and it said "catalog" so I think that means I have the right name for it.
|
@summer-cook the catalog page is not loading the same masthead file as the other pages. I have a custom _masthead.html.erb file that is being used everywhere but catalog. So the catalog gets the body classes from the file but when it gets to |
Story
I am working on a custom theme to use for our shared search tenant. I have customized the masthead section that shows underneath where the app name, language and login parts are. (see screenshots below) I have been looking at BL to figure out how to do this and for the thing I am having trouble with, i specifically used this file :
https://github.com/scientist-softserv/britishlibrary/blob/0c9299d6c16c2e60a1b91a71eba7a421081e55a1/app/views/hyrax/homepage/_banner_section.html.erb#L62
and put my version of that code into this page:
https://github.com/scientist-softserv/britishlibrary/blob/0c9299d6c16c2e60a1b91a71eba7a421081e55a1/app/views/themes/bl_shared_home/layouts/homepage.html.erb
The file I made is - app/views/themes/shared_repository/layouts/homepage.html.erb
Expected Behavior After Changes
It all seems to be working correctly except for the search results page. In my file on line 34 it is saying
<% if controller_name == 'catalog' %>that seems to have no affect, while the code above that for homepage, pages and contact_form
<% if controller_name == 'homepage' || controller_name == 'pages' || controller_name == 'contact_form' %>all work output the code that is there for those pages.
Additionally the footer.html.erb file in app/views/themes/shared_repository/shared/_footer.html.erb is working everywhere but on the search results page. This seems likely related.
Screenshots / Video
masthead section before
mast head section with the new theme
masthead section with new theme not working on the search results page
Footer with the theme working:
footer not working on the search results page
Notes
I see in app/controllers/hyrax there are files for pages_controller.rb, homepage_controller.rb and contact_form_controller.rb but not catalog_controller.rb - that one is one level up. I dont know if this has anything to do with it. I am thinking this because BL's references to <% if controller_name == 'catalog' %> are not inside a theme and maybe that affects how that works or doesnt work.