Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted hostnames alphabetically + Whitelist some large pool #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frugan-dev
Copy link
Contributor

@schweikert Wouldn't it be a good idea to sort the records alphabetically, to make the file more readable?

@frugan-dev frugan-dev changed the title Whitelist some large pool Sorted hostnames alphabetically + Whitelist some large pool Feb 9, 2024
@fleish
Copy link

fleish commented Feb 29, 2024

I personally prefer it to be sorted chronologically. You can always pass it through sort to see it alphabetically if you want.

@frugan-dev
Copy link
Contributor Author

@fleish well.. we're using git: it handles the history!

@fleish
Copy link

fleish commented Feb 29, 2024

Well, sure we are using git here ... but I'm not running git on my mail servers

@frugan-dev
Copy link
Contributor Author

@fleish IMHO we should think about what objectively makes sense at a global level, and not what we personally like at a local level.
Even indicating the dates in the comments doesn't make much sense, since git takes care of keeping track of them

@fleish
Copy link

fleish commented Feb 29, 2024

I get your point of view, but also don't see how alphabetizing makes any more sense at a global level than the current sort method. There are also multiple ways this software gets distributed outside of git (even downloading the zip file from git excludes the actual git back-end data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants