Scoped enums for PyQt6 proper support #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've updated each Qt enum so that they work both with PyQt5 and PyQt6 without any major hacking.
I also updated the INSTALL file to reflect changes to
pip install .since pip23 and pip24, where all arguments must be in a key=value form. I took the liberty to change how some optional dependencies can be set/unset to be more explicit (--no-libxmlis now--libxml=false), and as far as I've checked, they are not used in the current github workflow.On Linux, Pymol has a dash/dock gear icon and WMCLASS "python3", I've fixed this so now it exports the correct WMCLASS (which for gnome means that it is now able to find the correct icon).
I couldn't find how to set
PYMOL_PATHin a way thatpip install .is able to listen:pip install . --config-settings pymol-path=/some/pathpip install . --config-settings pymol_path=/some/pathvenvprefix/bin/pymolorpythonuserbase/bin/pymol):PYMOL_PATH=/some/path/ pip install .env PYMOL_PATH=/some/path/ pip install .