Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_utils.compatible_with #372

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

speleo3
Copy link
Contributor

@speleo3 speleo3 commented Jun 10, 2024

Fixes #370

Solution is similar to

def tupleize_version(strversion):
r = []
for x in strversion.split('.'):
try:
r.append(int(x))
except ValueError:
break
return tuple(r)

@JarrettSJohnson JarrettSJohnson merged commit 9d01072 into schrodinger:master Jun 10, 2024
2 of 5 checks passed
@JarrettSJohnson
Copy link
Member

Thanks. This uncovered some issues; I'll double check these on other machines.

@speleo3 speleo3 deleted the fix-compatible_with branch July 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_utils.requires_version("3.0") seems broken
2 participants