Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python version bound #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lrauschning
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Is the commit message clear and explains what the PR does?
  • Is the PR tested?
  • Are tests for the changes available and added (for bug fixes / features)
  • If needed, docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Removes the version bound to python 3.10 in the syri conda recipe.
    Syri works fine with python 3.12.7, I think the reason for the bound was originally because pysam did not support recent versions of python.

  • What is the current behavior? (You can also link to an open issue here)
    Conda in some cases gives a mistake trying to install syri to an env with python > 3.10 installed.

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@lrauschning
Copy link
Contributor Author

for some reason the diff displays the newline at the end of the file, not sure why. Didn't change anything else in the file.

@lrauschning
Copy link
Contributor Author

Hm, also pushing SyRI to pypi might be something worth thinking about.
Given that we use pip for packaging, it should work out of the box and make it possible to avoid conda altogether/rely on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant