Added the ability to create JS function compilers #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormal compilation process for a twig function when its compiled for javascript.
| // the method signature as it requires. | ||
| $functionCompiler = $compiler->getFunctionCompiler($node->getAttribute('name')); | ||
| $functionCompiler->compile($compiler, $node); | ||
| return; |
There was a problem hiding this comment.
Please add a blank line before this one.
… priortized or opt-out if they don't support a particular node.
|
This PR looks like it's stalled, having sat dormant for almost 18 months. I'm gonna close it for now so that the open issue queue can be kept for still-ongoing issues. Feel free to reopen immediately if you wanna pick the process back up though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to create a function compiler which overrides the normal compilation process for a twig function when its compiled for javascript.
This patch is required for the changes in issue 22 of the JMSTwigJSBundle.