Added initial inline js routing functionality #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #22 for the original idea. Comments on the implementation would be appreciated. This PR still needs:
|
| if ($routeNode instanceof Twig_Node_Expression_Constant) { | ||
| $routeName = $routeNode->getAttribute('value'); | ||
| } else { | ||
| $compiler |
There was a problem hiding this comment.
Just looking at this, I think it would make sense to instead fallback to the default compilation in cases where the route name is dynamic.
We could add some sort isHandled(\Twig_Node $node) function to the FunctionCompilerInterface. What do you think?
|
PR is ancient - cleaning up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiles routing information to inline js closures negating the need to use an external js routing library.
This PR is a work in progress and isn't ready to be merged yet.