Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file_link filter only when available #593

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Jan 7, 2025

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License Apache2

Description

file_link filter in twig is not always available and was recently moved from the Twig bridge to the WebProfiler bundle, which requires to have the web profiler enabled for it to work.
This ensures the filter is defined (now that guard tag was introduced). This requires to bump the minimum Twig version to at least 3.15.

@deguif deguif force-pushed the guard-file-link-filter branch 3 times, most recently from 8b9cd82 to ec6d32b Compare January 7, 2025 09:12
@deguif deguif force-pushed the guard-file-link-filter branch from ec6d32b to 42526ed Compare January 7, 2025 09:16
@goetas goetas merged commit 280f0e9 into schmittjoh:master Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants