Irasa sprint improvements #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 6, 2024 19:15
|
Issues resolved, example added and testing intensified :) merging |
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr tackles some core issues with pyrasa_sprint. There was sth wrong with the previous implementation that resulted in some weird artifacts from time to time. This is fixed now alongside #22 , #30 and #31. However, in order to do so I had to go back to use scipy.signal.stft which was recently marked a legacy function from scipy. @thht there are ways to tweak the newer scipy.signal.ShortTimeFFT towards producing an output like scipy.signal.stft (see Comparison with Legacy Implementation in https://docs.scipy.org/doc/scipy/tutorial/signal.html#tutorial-stft), but I didnt manage to do so yet..