Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Knee Testing #38

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Improved Knee Testing #38

merged 11 commits into from
Jul 31, 2024

Conversation

schmidtfa
Copy link
Owner

This pr aims to improve the knee testing functionality. When succesful we can close #28 and #29

@schmidtfa
Copy link
Owner Author

schmidtfa commented Jul 30, 2024

@thht can you check this out and cache the mne stuff. I think we can close this issue afterwards :)

at least as soon as i manage to properly load npy files 🙃

@thht
Copy link
Collaborator

thht commented Jul 31, 2024

can you check this out and cache the mne stuff.

Actually, I don't think this makes much sense. Caching means that the data is tarred and gzipped and then uploaded to a host and the next job just downloads it and untars/gzips it. So, basically what fetching the dataset does in the first place.

An easier route would be to use the testing dataset instead of the sample one. It contains all the files you need and it is stored on codeload.github.com which should be an internal github server. This should increase the download speed because the sample dataset is hosted on osf which is an external server.

@thht thht mentioned this pull request Jul 31, 2024
@thht thht mentioned this pull request Jul 31, 2024
@schmidtfa
Copy link
Owner Author

Thanks for adding the files to lfs @thht. Tests seem to work so if you are happy lets merge and close some issues :)

@thht
Copy link
Collaborator

thht commented Jul 31, 2024

Sure, punch it!

@schmidtfa schmidtfa merged commit 87a384d into main Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pregenerate / safe data for tests in designated folder
2 participants