Skip to content

Commit

Permalink
Merge pull request #1242 from scheduleonce/staging-app2
Browse files Browse the repository at this point in the history
Merging staging-app2 in to master.
  • Loading branch information
OhTanishJain authored Jul 26, 2024
2 parents 4a1db43 + b31a4a2 commit 70e94e3
Show file tree
Hide file tree
Showing 10 changed files with 46 additions and 15 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [8.0.25] - 2024-07-08

- [ONCEHUB-82598](https://scheduleonce.atlassian.net/browse/ONCEHUB-82598) fix: Occasionally, when hovering over elements that contain ouiToolTips, an unusual box appears.

## [8.0.24] - 2024-07-10

- [ONCEHUB-83691](https://scheduleonce.atlassian.net/browse/ONCEHUB-83691) update: change the color of help icon.

## [8.0.23] - 2024-07-08

- [ONCEHUB-83691](https://scheduleonce.atlassian.net/browse/ONCEHUB-83691) update: package update for additional information icon in the same place across the platform.

## [8.0.22] - 2024-06-28

- [ONCEHUB-83609](https://scheduleonce.atlassian.net/browse/ONCEHUB-83609) update: package update for ws, socket.io and puppeteer
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "oncehub-ui",
"version": "8.0.22",
"version": "8.0.26",
"scripts": {
"ng": "ng",
"build": "ng build ui",
Expand Down
4 changes: 2 additions & 2 deletions ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@oncehub/ui",
"version": "8.0.22",
"version": "8.0.26",
"description": "Oncehub UI",
"peerDependencies": {},
"repository": {
Expand Down
9 changes: 5 additions & 4 deletions ui/src/components/dialog/dialog-content.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class OuiDialogHeaderAction {
@Component({
// eslint-disable-next-line @angular-eslint/component-selector
selector: '[oui-dialog-header-article], [ouiDialogHeaderArticle]',
template: '<oui-icon svgIcon="article-icon"></oui-icon>',
template: '<oui-icon svgIcon="help-library"></oui-icon>',
exportAs: 'ouiDialogHeaderArticle',
// eslint-disable-next-line @angular-eslint/no-host-metadata-property
host: {
Expand All @@ -103,9 +103,10 @@ export class OuiDialogHeaderArticle implements OnDestroy {
private _focusMonitor: FocusMonitor,
private _ngZone: NgZone
) {
this.ouiIconRegistry.addSvgIconLiteral(
`article-icon`,
this.domSanitizer.bypassSecurityTrustHtml(ICONS.ARTICLE_ICON)
this.ouiIconRegistry.addSvgIconSet(
this.domSanitizer.bypassSecurityTrustResourceUrl(
'https://cdn.icomoon.io/135790/oncehub-20/symbol-defs.svg?5df5gz'
)
);
this._monitorSubscription = this._focusMonitor
.monitor(this.elementRef, true)
Expand Down
5 changes: 3 additions & 2 deletions ui/src/components/dialog/dialog.scss
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,14 @@ $header-icon-height: 24px;
.oui-icon {
width: 16px;
height: 20px;
padding-top: 3px;
svg {
vertical-align: top;
fill: #4a4a4a;
}
}
&[class^='cdk'],
&[class$='focused'] {
&[class$='focused'],
&:hover {
background: $icon-focus-background;
border-radius: 2px;
transition: $icon-focus-transition;
Expand Down
13 changes: 12 additions & 1 deletion ui/src/components/tabs/tab-nav-bar/tab-link.scss
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,17 @@
border: 1px solid #006bb1 !important;
border-bottom: 0 !important;
}
&.active {
.mdc-tab__content .mdc-tab__text-label {
color: #333;
}
}
&:first-child {
margin-left: 0;
}
&:last-child {
margin-right: 0;
}
}
.mdc-tab-indicator {
display: flex;
Expand Down Expand Up @@ -71,7 +82,7 @@
font-size: 16px;
line-height: 22px;
font-weight: 600;
color: #333;
color: #666;
display: inline-flex;
align-items: center;
}
Expand Down
8 changes: 7 additions & 1 deletion ui/src/components/tooltip/tooltip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,11 @@ export class OuiTooltip implements OnDestroy, CanDisable {
hide(): void {
if (this._tooltipInstance) {
this._tooltipInstance.hide();
} else {
if (this._overlayRef) {
this._overlayRef.dispose();
this._overlayRef = null;
}
}
}

Expand Down Expand Up @@ -559,7 +564,8 @@ export class OuiTooltip implements OnDestroy, CanDisable {
/** Detaches the currently-attached tooltip. */
private _detach() {
if (this._overlayRef && this._overlayRef.hasAttached()) {
this._overlayRef.detach();
this._overlayRef.dispose();
this._overlayRef = null;
}

this._tooltipInstance = null;
Expand Down
2 changes: 1 addition & 1 deletion ui/src/stories/icon/icon.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class OuiiconStorybook {

this.ouiIconRegistry.addSvgIconSet(
this.domSanitizer.bypassSecurityTrustResourceUrl(
'https://cdn.icomoon.io/135790/oncehub-20/symbol-defs.svg?81ot1f'
'https://cdn.icomoon.io/135790/oncehub-20/symbol-defs.svg?5df5gz'
)
);
}
Expand Down

0 comments on commit 70e94e3

Please sign in to comment.