Add check-substrait-extensions to pre-commit

scgkiran · Sep 12, 2024 · 0f672bc · 0f672bc
1 parent 5a36340
commit 0f672bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -21,3 +21,11 @@ repos:
   rev: 6.1.0
   hooks:
   - id: flake8
+- repo: local
+  hooks:
+  - id: check-substrait-extensions
+    name: Check Substrait extensions
+    entry: pytest tests/test_extensions.py::test_read_substrait_extensions
+    language: python
+    pass_filenames: false
+
diff --git a/tests/test_extensions.py b/tests/test_extensions.py
@@ -1,11 +1,16 @@
 # SPDX-License-Identifier: Apache-2.0
+import os
+
 from tests.coverage.extensions import build_type_to_short_type
 
 
+# NOTE: this test is run as part of pre-commit hook
 def test_read_substrait_extensions():
     from tests.coverage.extensions import Extension
 
-    registry = Extension.read_substrait_extensions("../extensions")
+    current_dir = os.path.dirname(os.path.abspath(__file__))
+    extensions_path = os.path.join(current_dir, "../extensions")
+    registry = Extension.read_substrait_extensions(extensions_path)
     assert len(registry.registry) >= 161
     num_overloads = sum([len(f) for f in registry.registry.values()])
     assert num_overloads >= 510