Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook-table): controls for overflow #811

Merged

Conversation

theJohnnyMe
Copy link
Contributor

Describe pull-request

Adding missing config for storybook controls on expandable story

Issue Linking:

  • No issue: Issue spotted "on-fly"

How to test

  1. Go to preview link
  2. Check Table Expandable rows story
  3. Check that overflow control has default "auto" and possibility to switch to "hidden" and "visible"

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Playwright test results

failed  1 failed
passed  389 passed
skipped  1 skipped

Details

stats  391 tests across 132 suites
duration  53 seconds
commit  2c12663

Failed tests

src/components/popover-menu/test/default/popover-menu.e2e.ts › tds-popover-menu-default › clicking the trigger button should open the popover menu dialog

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-811.d3fazya28914g3.amplifyapp.com

Copy link
Collaborator

@ckrook ckrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@nathalielindqvist nathalielindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

Copy link
Collaborator

@Lunkan89 Lunkan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't these changes in #793 also?

@theJohnnyMe theJohnnyMe reopened this Oct 25, 2024
Copy link

sonarcloud bot commented Oct 25, 2024

@theJohnnyMe
Copy link
Contributor Author

I am bringing this back as the develop branch does not have correct controls again.

@theJohnnyMe theJohnnyMe merged commit 30a710e into develop Oct 25, 2024
3 of 4 checks passed
@theJohnnyMe theJohnnyMe deleted the docs(storybook-table)--default-state-for-control branch October 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants