Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/table: Add a property to control whether padding is applied to the expanded area of an expanded table row #787

Closed
wants to merge 6 commits into from

Conversation

patrikhultgren
Copy link
Collaborator

@patrikhultgren patrikhultgren commented Oct 7, 2024

Describe pull-request

Add a property to control whether padding is applied to the expanded area of an expanded table row.

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to Table -> "Expandable Rows" in Storybook.
  2. Go to Docs and set "Expanded padding enabled" to false.
  3. Expand a row and you will see that the padding is gone.

Checklist before submission

  • All existing tests pass
  • Added e2e test
  • Not breaking production behavior
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)

Screenshot

Desired result:
no-padding

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Playwright test results

passed  388 passed

Details

stats  388 tests across 131 suites
duration  51.9 seconds
commit  9e4ee43

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-787.d3fazya28914g3.amplifyapp.com

@patrikhultgren patrikhultgren changed the title Feat/table: Add a prop to control whether padding is applied to the expanded area of an expanded table row Feat/table: Add a property to control whether padding is applied to the expanded area of an expanded table row Oct 7, 2024
Copy link

sonarcloud bot commented Oct 7, 2024

@patrikhultgren
Copy link
Collaborator Author

I believe this issue can be addressed more effectively with this simpler pull request instead:
#789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant