feat(serverless): remove default on http-option (#4152)

scaleway · Oct 2, 2024 · 0b74d86 · 0b74d86
1 parent 3a9d72b
commit 0b74d86
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 9 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-container-container-update-usage.golden b/cmd/scw/testdata/test-all-usage-container-container-update-usage.golden
@@ -22,7 +22,7 @@ ARGS:
  [port] 
  [secret-environment-variables.{index}.key] 
  [secret-environment-variables.{index}.value] 
- [http-option=enabled] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
+ [http-option]  Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
  [sandbox] Execution environment of the container (unknown_sandbox | v1 | v2)
  [local-storage-limit] Local storage limit of the container (in MB)
  [region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

diff --git a/cmd/scw/testdata/test-all-usage-function-function-update-usage.golden b/cmd/scw/testdata/test-all-usage-function-function-update-usage.golden
@@ -19,7 +19,7 @@ ARGS:
  [description] Description of the function
  [secret-environment-variables.{index}.key] 
  [secret-environment-variables.{index}.value] 
- [http-option=enabled] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
+ [http-option]  Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
  [sandbox] Execution environment of the function (unknown_sandbox | v1 | v2)
  [region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
 

diff --git a/docs/commands/container.md b/docs/commands/container.md
@@ -199,7 +199,7 @@ scw container container update <container-id ...> [arg=value ...]
 | port | | |
 | secret-environment-variables.{index}.key | | |
 | secret-environment-variables.{index}.value | | |
-| http-option | Default: `enabled`<br />One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
+| http-option | One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
 | sandbox | One of: `unknown_sandbox`, `v1`, `v2` | Execution environment of the container |
 | local-storage-limit | | Local storage limit of the container (in MB) |
 | region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |

diff --git a/docs/commands/function.md b/docs/commands/function.md
@@ -461,7 +461,7 @@ scw function function update <function-id ...> [arg=value ...]
 | description | | Description of the function |
 | secret-environment-variables.{index}.key | | |
 | secret-environment-variables.{index}.value | | |
-| http-option | Default: `enabled`<br />One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
+| http-option | One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
 | sandbox | One of: `unknown_sandbox`, `v1`, `v2` | Execution environment of the function |
 | region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
 

diff --git a/go.mod b/go.mod
@@ -26,7 +26,7 @@ require (
  github.com/mattn/go-isatty v0.0.20
  github.com/moby/buildkit v0.13.2
  github.com/opencontainers/go-digest v1.0.0
- github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20240918143018-367e0bbfa46e
+ github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241001085744-c3abf300c911
  github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
  github.com/spf13/cobra v1.8.1
  github.com/spf13/pflag v1.0.5

diff --git a/go.sum b/go.sum
@@ -465,8 +465,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
 github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20240918143018-367e0bbfa46e h1:pun/kzFkKXoXMCnx8O63eLDz69uk0ggjV+OAnbjpw3w=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20240918143018-367e0bbfa46e/go.mod h1:o/2twhmcz4HlhtuuubCuwQ/fe+zyzoJR85+02gy04yY=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241001085744-c3abf300c911 h1:IwmIIQaLdCx38LeWFIJqNqF8qHTCEdSecY5k5D5LI0k=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.30.0.20241001085744-c3abf300c911/go.mod h1:o/2twhmcz4HlhtuuubCuwQ/fe+zyzoJR85+02gy04yY=
 github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
 github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
 github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=

diff --git a/internal/namespaces/container/v1beta1/container_cli.go b/internal/namespaces/container/v1beta1/container_cli.go
@@ -737,7 +737,6 @@ func containerContainerUpdate() *core.Command {
  Required: false,
  Deprecated: false,
  Positional: false,
- Default: core.DefaultValueSetter("enabled"),
  EnumValues: []string{"unknown_http_option", "enabled", "redirected"},
  },
  {

diff --git a/internal/namespaces/function/v1beta1/function_cli.go b/internal/namespaces/function/v1beta1/function_cli.go
@@ -738,7 +738,6 @@ func functionFunctionUpdate() *core.Command {
  Required: false,
  Deprecated: false,
  Positional: false,
- Default: core.DefaultValueSetter("enabled"),
  EnumValues: []string{"unknown_http_option", "enabled", "redirected"},
  },
  {