Feature/SK-1257 | Bugfixes and improvements of combiner, and new load test #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 13, 2024 15:51
ahellander
changed the title
Wrede
requested changes
Jan 8, 2025
|
|
||
| Standing in examples/load-test | ||
| ``` | ||
| pip install -r requirements.txt |
examples/load-test/README.md
Outdated
| way by sending and aggregating numeric arrays of varying size. | ||
|
|
||
| ## Prerequisites | ||
| - [Python 3.9 or 3.10](https://www.python.org/downloads) |
Wrede
requested changes
Jan 15, 2025
| @@ -160,7 +160,7 @@ def get_or_set_environment(self) -> bool: | |||
| self.dispatcher.run_cmd("startup") | |||
| except KeyError: | |||
| logger.info("No startup command found in package. Continuing.") | |||
| return False | |||
| # return False | |||
| @@ -215,6 +215,7 @@ def update_local_model(self, request): | |||
| return | |||
|
|
|||
| fetch_model_time = time.time() - tic | |||
| print("FETCH_MODEL: ", fetch_model_time) | |||
| @@ -237,6 +238,7 @@ def update_local_model(self, request): | |||
| tic = time.time() | |||
| self.send_model_to_combiner(model=out_model, id=model_update_id) | |||
| meta["upload_model"] = time.time() - tic | |||
| print("UPLOAD_MODEL ", meta["upload_model"]) | |||
| @@ -122,7 +124,7 @@ def heartbeat(self, client_name: str, client_id: str): | |||
| heartbeat = fedn.Heartbeat(sender=fedn.Client(name=client_name, role=fedn.CLIENT, client_id=client_id)) | |||
|
|
|||
| try: | |||
| logger.info("Sending heartbeat to combiner") | |||
| # logger.info("Sending heartbeat to combiner") | |||
| @@ -142,7 +144,8 @@ def send_heartbeats(self, client_name: str, client_id: str, update_frequency: fl | |||
| except Exception as e: | |||
| return self._handle_unknown_error(e, "SendHeartbeat", lambda: self.send_heartbeats(client_name, client_id, update_frequency)) | |||
| if isinstance(response, fedn.Response): | |||
| logger.info("Heartbeat successful.") | |||
| pass | |||
| # logger.info("Heartbeat successful.") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a new load test based on reading, writing and sending numpy arrays. Resolves bugs;