Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/SK-1193 | Handle unknown error, reconnect channel #743

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Nov 11, 2024

This pull request introduces a new test suite for gRPC communication with simulated network conditions using Toxiproxy, and includes several enhancements and refactors in the GrpcHandler class to improve error handling and channel management.

New Test Suite for gRPC Communication:

  • Added TestGRPCWithToxiproxy class in .ci/tests/chaos_test.py to test gRPC communication under various network conditions using Toxiproxy.

Enhancements in GrpcHandler:

  • Refactored GrpcHandler initialization to include a new _init_channel method and _init_stubs method for better channel and stub management.
  • Added logging for gRPC errors in heartbeat, send_heartbeats, and listen_to_task_stream methods to improve error visibility. [1] [2] [3]
  • Introduced _handle_unknown_error method to handle non-gRPC specific exceptions by attempting to reconnect and reinitialize stubs.

@Wrede Wrede merged commit 3e1dcd7 into master Nov 19, 2024
19 checks passed
@Wrede Wrede deleted the bugfix/SK-1193 branch November 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants