Feature/SK-1071 | Initial refactor of client #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Wrede
changed the title
Wrede
changed the title
Wrede
approved these changes
Oct 9, 2024
ahellander
reviewed
Oct 10, 2024
| # Enum for respresenting the result of connecting to the FEDn API | ||
| class ConnectToApiResult(enum.Enum): | ||
| Assigned = 0 | ||
| ComputePackgeMissing = 1 |
There was a problem hiding this comment.
Spelling error . ComputePackge-Z ComputePackage
There was a problem hiding this comment.
Will fix this.
ahellander
approved these changes
Oct 10, 2024
| else: | ||
| raise ValueError(f"Unsupported event type: {event_type}") | ||
|
|
||
| def notify_subscribers(self, event_type: str, *args, **kwargs): |
There was a problem hiding this comment.
I don't understand, what subscribers might a client have?
There was a problem hiding this comment.
@ahellander if you look in the client_v2.py file you can see how it is used. The overall idea is that client_api exposes functionality that a client can then make use of... In this particular example the client subscribes to events raised from the client_api. Events include training, validation or inference.
There was a problem hiding this comment.
I will add a little example too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fedn client start-v2 command added
OBS this PR does not replace the current client, it's and initial step to a new client (refactor)
Mainly tried to clean up the existing client. The existing client is left as is. The idea is to let this new solution exist in parallel until it can be the main solution. The functionality of the client is divided into three main classes, GrpcHandler, ClientApi and the "new" Client class. The Client class implements the ClientApi. The Client class can be understood as an example of how to set up your own client.