Speakers new layout #251
Open
Speakers new layout #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duncanphillips
commented
Jan 11, 2017
duncanphillips
commented
duncanphillips
commented
Jan 11, 2017
| <b>{{ speaker.name }}</b><br/> | ||
| {{ speaker.company}} | ||
| </p> | ||
| <a href="/speakers/{{ speaker.year }}#{{ speaker.name | slugify }}"> |
There was a problem hiding this comment.
speakers on home page are now linked properly
vhata
requested changes
Jan 11, 2017
| <p> {{ speaker.bio }} </p> | ||
| <div class="row nested-row"> | ||
| <div class="col-md-offset-1 col-md-11"> | ||
| <p> {{ speaker.bio }} </p> |
There was a problem hiding this comment.
Can we move the speaker bio below the abstract? The abstract is the important thing here - people are here for the talks, not to learn about the speakers lives.
| <p>The title of the talk is <i>"{{ speaker.title }}"</i>.</p> | ||
| <div class="row nested-row"> | ||
| <div class="col-md-offset-1 col-md-11"> | ||
| <p>The title of the talk is <i>"{{ speaker.title }}"</i>.</p> |
There was a problem hiding this comment.
This is weird. "The title of the talk is X". Can we make it look like a title, and put it with the abstract in a more prominent position? This page is basically listing the talks with their titles and abstracts, so it should look more like it.
| {% for speaker in page_speakers %} | ||
| <div id='{{ speaker.name | slugify }}'> | ||
| <div class="row text-center"> | ||
| <h2>{{ speaker.name }}</h2> |
There was a problem hiding this comment.
These names are huge. Again, could we make the talk title bigger and more titley, maybe combine them with the name here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.