Add table metadata service #2434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ypeckstadt
requested review from
komamitsu,
brfrn169,
feeblefakie and
Torch3333
komamitsu
reviewed
Dec 20, 2024
|
|
||
| /** The namespace of the table in ScalarDB. */ | ||
| @JsonProperty("namespace") | ||
| private String namespace; |
There was a problem hiding this comment.
[minor] This seems the name of a namespace as well as the name of a table below. So, this should be namespaceName for consistency?
| @Getter | ||
| public class TableMetadataRequest { | ||
|
|
||
| private final String namespace; |
| * | ||
| * @return A set of predefined metadata column names. | ||
| */ | ||
| public static Set<String> getMetadataColumns() { |
There was a problem hiding this comment.
How about using com.scalar.db.transaction.consensuscommit.ConsensusCommitUtils#getTransactionMetaColumns to avoid duplicated logic?
Some other methods might be replaced with ConsensusCommitUtils methods.
brfrn169
reviewed
Dec 20, 2024
| * @param columnNames A set of all column names in the table. | ||
| * @return {@code true} if the column is a metadata column; {@code false} otherwise. | ||
| */ | ||
| public static boolean isMetadataColumn( |
There was a problem hiding this comment.
You can use ConsensusCommitUtils.isTransactionMetaColumn():
| * @param tableMetadata The metadata of the table. | ||
| * @return {@code true} if the column is a metadata column; {@code false} otherwise. | ||
| */ | ||
| public static boolean isMetadataColumn(String columnName, TableMetadata tableMetadata) { |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added table metadata service and some related DTO classes
Related issues and/or PRs
NA
Changes made
Added table metadata service and some related DTO classes. The tablemetadata service is also used in data loader API.
The spotbug exlude is the same as the one added in other PR to resolve issue due lombok.
Checklist
Additional notes (optional)
Road map to merge remaining data loader core files. Current status
General
Export
Import
Release notes
NA