Export options and basic export report dto #2397
Conversation
ypeckstadt
requested review from
brfrn169,
komamitsu,
feeblefakie and
Torch3333
| @@ -34,4 +34,9 @@ | |||
| <Bug pattern="ODR_OPEN_DATABASE_RESOURCE"/> | |||
| </Or> | |||
| </Match> | |||
| <!-- Ignore mutable object exposure warnings(caused by Lombok) for all classes in dataloader.core --> | |||
| <Match> | |||
There was a problem hiding this comment.
Lombok does not work well with Spotbugs. To avoid having to disable the bug patterns for all projects, the rules are only disabled for the com.scalar.db.dataloader.core.* package.
| * exported file. AtomicInteger is used because it is thread safe and this parameter is a counter | ||
| * which is updated inside threads | ||
| */ | ||
| private final AtomicInteger exportedRowCount; |
There was a problem hiding this comment.
[minor] This can be initialized here.
There was a problem hiding this comment.
I have moved the initialisation as suggested (I have changed AtomicInteger to LongAdder based on Suzuki-san suggestion).
Thank you.
| * exported file. AtomicInteger is used because it is thread safe and this parameter is a counter | ||
| * which is updated inside threads | ||
| */ | ||
| private final AtomicInteger exportedRowCount; |
There was a problem hiding this comment.
LongAdder might be useful here:
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/atomic/LongAdder.html
There was a problem hiding this comment.
Thank you for the suggestion.
I have replaced AtomicInteger with LongAdder.
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class ExportReportTest { |
There was a problem hiding this comment.
| public class ExportReportTest { | |
| class ExportReportTest { |
There was a problem hiding this comment.
I have updated it as suggested.
Thank you.
There was a problem hiding this comment.
It looks like it's not updated?
There was a problem hiding this comment.
@brfrn169
My apologies, I think I missed to commit the file. I have pushed the change now.
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Co-authored-by: Peckstadt Yves <[email protected]>
Description
Added export options builder and export report class
Related issues and/or PRs
PR dependency
Changes made
Added export options builder and export report class
Checklist
Additional notes (optional)
This PR is part of the on-going process of merging all ScalarDB Data Loader code into the main repository.
Release notes
NA