Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB Connector/J JDBC driver #2391

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Dec 6, 2024

Description

So far, ScalarDB has been using the Mysql JDBC driver for both MySQL and MariaDB, but the driver does not support fractional seconds for time-related types when used with MariaDB 10.11.
The reason is that the MariaDB server returns a version number that does not follow the MySQL version standard and is incorrectly parsed by the MySQL driver which causes it to disable fractional seconds support.
This issue does not occur with MariaDB 11.4 though.

To address the issue, the dedicated MariaDB Connector/J JDBC driver will be used for any connection URL starting with jdbc:mariadb

Related issues and/or PRs

N/A

Changes made

Add the MariaDB JDBC driver.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Release notes

Use the MariaDB Connector/J JDBC driver for any connection URL starting with jdbc:mariadb

@Torch3333 Torch3333 self-assigned this Dec 6, 2024
@Torch3333 Torch3333 force-pushed the add_mariadb_jdbc_driver branch from 31f126f to c0821cb Compare December 10, 2024 02:01
@Torch3333 Torch3333 added enhancement New feature or request improvement and removed improvement enhancement New feature or request labels Dec 12, 2024
@Torch3333 Torch3333 changed the title Add MariaDB JDBC driver Add MariaDB Connector/J JDBC driver Dec 12, 2024
…iadb_jdbc_driver

# Conflicts:
#	build.gradle
@Torch3333 Torch3333 marked this pull request as ready for review December 12, 2024 04:31
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 8fb38aa into master Dec 18, 2024
48 checks passed
@brfrn169 brfrn169 deleted the add_mariadb_jdbc_driver branch December 18, 2024 06:48
feeblefakie pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants