Refactoring CoordinatorGroupCommitKeyManipulator
by moving the implementation to DefaultGroupCommitKeyManipulator
to improve the reusability
#2389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current implementation,
CoordinatorGroupCommitKeyManipulator
designed to manipulate GroupCommit keys that are all String. But, the functionality should be reusable in other use cases, not only for the Coordinator Group Commit feature. This PR moves the implementation ofCoordinatorGroupCommitKeyManipulator
toDefaultGroupCommitKeyManipulator
to make the functionality easier to reuse.Related issues and/or PRs
Changes made
CoordinatorGroupCommitKeyManipulator
toDefaultGroupCommitKeyManipulator
.CoordinatorGroupCommitKeyManipulator
inheritsDefaultGroupCommitKeyManipulator
now.KeyManipulator
toGroupCommitKeyManipulator
to clarify what kind of keys the interface manipulate.Checklist
Additional notes (optional)
This changes addresses this issue.
Release notes
N/A