Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ThrowableConsumer #1373

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add ThrowableConsumer #1373

merged 1 commit into from
Dec 14, 2023

Conversation

brfrn169
Copy link
Collaborator

Description

This PR adds a utility class ThrowableConsumer which can be used in ScalarDB ecosystem.

Related issues and/or PRs

N/A

Changes made

  • Added ThrowableConsumer
  • Refactored ThrowableFunction

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Dec 12, 2023
komamitsu
komamitsu approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

feeblefakie
feeblefakie approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit bb56373 into master Dec 14, 2023
23 checks passed
@brfrn169 brfrn169 deleted the add-ThrowableConsumer branch December 14, 2023 06:59
feeblefakie pushed a commit that referenced this pull request Dec 14, 2023
@brfrn169
Add ThrowableConsumer (#1373)
a977d4d
@feeblefakie feeblefakie mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@komamitsu komamitsu komamitsu approved these changes

@Torch3333 Torch3333 Awaiting requested review from Torch3333

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brfrn169 @komamitsu @feeblefakie