Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to Admin.importTable() #1337

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add options to Admin.importTable() #1337

merged 1 commit into from
Nov 30, 2023

Conversation

brfrn169
Copy link
Collaborator

Description

This PR applied part of the change in #1260, especially adding the options argument to the Admin.importTable() method, to the branch 3.

Related issues and/or PRs

Changes made

  • Added the options argument to the Admin.importTable() method

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

Copy link
Contributor

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing it! I should have handled it :-(

@komamitsu
Copy link
Contributor

@brfrn169 The following files changed in https://github.com/scalar-labs/scalardb/pull/1260/files don't seem to be included in this PR (I didn't throughly check all the changes of the PR). Is it okay to skip them?

  • integration-test/src/main/java/com/scalar/db/schemaloader/SchemaLoaderImportIntegrationTestBase.java
  • core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTableIntegrationTest.java
  • core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTestUtils.java
  • core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcSchemaLoaderImportIntegrationTest.java
  • core/src/integration-test/java/com/scalar/db/transaction/jdbc/JdbcTransactionAdminImportTableIntegrationTest.java

@brfrn169
Copy link
Collaborator Author

brfrn169 commented Nov 30, 2023

@komamitsu Thank you for checking that. Yes, we can skip the files because this PR only applies part of the change in #1260, especially adding the options argument to the Admin.importTable() method. Thanks.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@brfrn169 brfrn169 merged commit 51274f3 into 3 Nov 30, 2023
46 checks passed
@brfrn169 brfrn169 deleted the add-options-to-importTable branch November 30, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants