Backport to branch(3) : Add cross-partition scan options #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmt
commented
Nov 24, 2023
| @@ -24,6 +24,9 @@ public static Properties getProperties(@SuppressWarnings("unused") String testNa | |||
| props.setProperty(DatabaseConfig.CONTACT_POINTS, contactPoints); | |||
| props.setProperty(DatabaseConfig.USERNAME, username); | |||
| props.setProperty(DatabaseConfig.PASSWORD, password); | |||
| props.setProperty(DatabaseConfig.CROSS_PARTITION_SCAN, "true"); | |||
There was a problem hiding this comment.
Changed to true in v3.x.
jnmt
commented
Nov 24, 2023
| @@ -0,0 +1,6 @@ | |||
| package com.scalar.db.storage.cassandra; | |||
|
|
|||
| public class CassandraConfig { | |||
There was a problem hiding this comment.
In v3.x, there isn't CassandraConfig, but I added it to provide STORAGE_NAME, as the same as other storages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1294
Not just fixing the conflicts, but I changed the default value of the cross-partition scan option to keep backward compatibility in v3.x. Please take a quick look when you get a chance.