Skip to content

Commit

Permalink
Enable integration test skipped for YugabyteDB
Browse files Browse the repository at this point in the history
  • Loading branch information
komamitsu committed Dec 13, 2024
1 parent 9c1cd4a commit e680e84
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1520,7 +1520,7 @@ jobs:
steps:
- name: Run YugabyteDB 2
run: |
docker run -p 5433:5433 -e YSQL_USER=yugabyte -e YSQL_PASSWORD=yugabyte -d yugabytedb/yugabyte:2.21.0.0-b545 bin/yugabyted start --background=false --master_flag="ysql_enable_db_catalog_version_mode=false" --tserver_flags="ysql_enable_db_catalog_version_mode=false"
docker run -p 5433:5433 -e YSQL_USER=yugabyte -e YSQL_PASSWORD=yugabyte -d yugabytedb/yugabyte:2.20.4.0-b50 bin/yugabyted start --background=false --master_flag="ysql_enable_db_catalog_version_mode=false" --tserver_flags="ysql_enable_db_catalog_version_mode=false"
- uses: actions/checkout@v4

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import com.scalar.db.io.DataType;
import java.util.Properties;
import java.util.Random;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIf;

public class JdbcDatabaseMultipleClusteringKeyScanIntegrationTest
extends DistributedStorageMultipleClusteringKeyScanIntegrationTestBase {
Expand Down Expand Up @@ -81,22 +79,4 @@ protected Column<?> getColumnWithMaxValue(String columnName, DataType dataType)
}
return super.getColumnWithMaxValue(columnName, dataType);
}

// TODO: Remove this once https://github.com/yugabyte/yugabyte-db/issues/22140 is fixed and the
// fix is released.
@DisabledIf("isYugabyteDb")
@Test
@Override
public void scan_WithSecondClusteringKeyRange_ShouldReturnProperResult()
throws java.util.concurrent.ExecutionException, InterruptedException {
super.scan_WithSecondClusteringKeyRange_ShouldReturnProperResult();
}

@DisabledIf("isYugabyteDb")
@Test
@Override
public void scan_WithSecondClusteringKeyRangeWithSameValues_ShouldReturnProperResult()
throws java.util.concurrent.ExecutionException, InterruptedException {
super.scan_WithSecondClusteringKeyRangeWithSameValues_ShouldReturnProperResult();
}
}

0 comments on commit e680e84

Please sign in to comment.